Moving Events interface methods to Messages interface
#773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LiranCohen
commented
Jun 26, 2024
•
LiranCohen
commented
- Rename EventsQuery to MessagesQuery
- Rename EventsSubscribe to MessagesSubscribe
- Move Events types to Messages types
- Move Events grant authorization to Messages grant authorization
LiranCohen
force-pushed
the
lirancohen/events-to-messages
branch
from
a4faf47 to
355b371
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
- Coverage 98.69% 98.69% -0.01%
==========================================
Files 74 73 -1
Lines 11268 11258 -10
Branches 1609 1609
==========================================
- Hits 11121 11111 -10
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
LiranCohen
changed the title
Events interface methods to Messages interfaceEvents interface methods to Messages interface
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
thehenrytsai
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.